Explicitly set clang-format PointerAlignment#353
Merged
MaartenS11 merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
It seems a recent clang-format change causes pointers to sometimes be left aligned while all our code uses right aligned pointers. This enforces right alignment at all times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems a recent clang-format change causes pointers to sometimes be left aligned while all our code uses right aligned pointers. This PR enforces right alignment at all times. Because of this change I would often have clang-format change the pointer alignment locally which then caused the CI to fail, this is now resolved.